[ipxe-devel] [ipxe/ipxe] [intelx] Added PCI_ROM entry for Intel x553/x557-AT and x553 (SFP+) NICs (#79)

Discussion:

Rob Taglang

2018-10-02 19:21:23 UTC

Tested on [SuperMicro A2SDi-H-TP4F](https://www.supermicro.com/products/motherboard/atom/A2SDi-H-TP4F.cfm) which has these NICs
You can view, comment on, or merge this pull request online at:

https://github.com/ipxe/ipxe/pull/79

-- Commit Summary --

* [intelx] Added PCI_ROM entry for Intel x553/x557-AT and x553 (SFP+) NICs

-- File Changes --

M src/drivers/net/intelx.c (2)

-- Patch Links --

https://github.com/ipxe/ipxe/pull/79.patch
https://github.com/ipxe/ipxe/pull/79.diff

--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/ipxe/ipxe/pull/79

Christian Nilsson

2018-10-02 19:27:48 UTC

Permalink

It would be good if the pciids are keept sorted

You might also want to read about preferred git commit message style:
http://ipxe.org/admin#commit_log_messages

--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/ipxe/ipxe/pull/79#issuecomment-426400215

Rob Taglang

2018-10-02 19:32:29 UTC

Permalink

http://ipxe.org/admin#commit_log_messages

Could you be more specific? Is there something wrong with this besides missing `Signed-off-by:`?

--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/ipxe/ipxe/pull/79#issuecomment-426401583

Rob Taglang

2018-10-02 19:43:03 UTC

Permalink

Updated

--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/ipxe/ipxe/pull/79#issuecomment-426404608